Skip to content

Ported the plugin to WP8#35

Merged
devgeeks merged 2 commits intodevgeeks:masterfrom
alex-swiftify:wp8
Jun 14, 2014
Merged

Ported the plugin to WP8#35
devgeeks merged 2 commits intodevgeeks:masterfrom
alex-swiftify:wp8

Conversation

@alex-swiftify
Copy link
Copy Markdown

No description provided.

@devgeeks
Copy link
Copy Markdown
Owner

Wouldn't this need a section in plugin.xml for the new platform as well?

@alex-swiftify
Copy link
Copy Markdown
Author

Good point! I just didn't include it. Will push an update.

Regards,
Alex

On Wednesday, 16 April 2014, tommy-carlos williams notifications@github.com
wrote:

Wouldn't this need a section in plugin.xml for the new platform as well?


Reply to this email directly or view it on GitHubhttps://github.com//pull/35#issuecomment-40545080
.

@alex-swiftify
Copy link
Copy Markdown
Author

I've added necessary changes to config.xml.
Should work now :)

@devgeeks
Copy link
Copy Markdown
Owner

devgeeks commented Jun 3, 2014

I am going to try and merge this in. Hopefully I will be able to test it using PhoneGap build and my Lumia 820.

@alex-swiftify
Copy link
Copy Markdown
Author

Sounds good - let me know how it works :)

------ Original Message ------
From: "tommy-carlos williams" notifications@github.com
To: "devgeeks/Canvas2ImagePlugin"
Canvas2ImagePlugin@noreply.github.com
Cc: "Alex Petuschak" petuschak@gmail.com
Sent: 03-Jun-14 9:51:26 AM
Subject: Re: [Canvas2ImagePlugin] Ported the plugin to WP8 (#35)

I am going to try and merge this in. Hopefully I will be able to test
it using PhoneGap build and my Lumia 820.


Reply to this email directly or view it on GitHub.

@devgeeks
Copy link
Copy Markdown
Owner

I finally managed to test this, sort of. It's looking pretty good, though I might have to add the photolib permission to the plugin.xml. I should be able to pull this in this weekend sometime.

Thanks so much for doing this.

@alex-swiftify
Copy link
Copy Markdown
Author

Sounds greats Tommy.
Yeah, adding permission makes sense.
Great if you've managed to do this.

Regards,
Alex

On Saturday, 14 June 2014, tommy-carlos williams notifications@github.com
wrote:

I finally managed to test this, sort of. It's looking pretty good, though
I might have to add the photolib permission to the plugin.xml. I should be
able to pull this in this weekend sometime.

Thanks so much for doing this.


Reply to this email directly or view it on GitHub
#35 (comment)
.

devgeeks added a commit that referenced this pull request Jun 14, 2014
Ported the plugin to WP8
@devgeeks devgeeks merged commit df9b11b into devgeeks:master Jun 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants