fix: retry PutConnectState on error, check ContentLength to avoid EOF error#102
Merged
devgianlu merged 4 commits intodevgianlu:masterfrom Sep 29, 2024
Merged
Conversation
devgianlu
requested changes
Sep 29, 2024
…sages to original value
devgianlu
approved these changes
Sep 29, 2024
thilojaeggi
pushed a commit
to thilojaeggi/go-librespot
that referenced
this pull request
Oct 13, 2024
mcMineyC
pushed a commit
to mcMineyC/go-librespot_embedded
that referenced
this pull request
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting 500 status with empty body randomly throughout the day when PutConnectState was called.
Have tested for a day or so and I am not getting EOF errors anymore.
Commit does:
Retrying the request (not sure how important that method is for the app to run properly) and checking ContentLength so we are not getting EOF errors during decoding JSON.