Skip to content

fix: update PlaybackSpeed when changing the IsPaused flag#106

Merged
devgianlu merged 1 commit intodevgianlu:masterfrom
aykevl:fix-PlaybackSpeed
Oct 1, 2024
Merged

fix: update PlaybackSpeed when changing the IsPaused flag#106
devgianlu merged 1 commit intodevgianlu:masterfrom
aykevl:fix-PlaybackSpeed

Conversation

@aykevl
Copy link
Copy Markdown
Contributor

@aykevl aykevl commented Oct 1, 2024

The PlaybackSpeed field must be set to 0 when paused. Otherwise Spotify Android will correctly show the stream as paused but will still move the playback position when redrawing the UI (and for a very short time when resuming playback).

Fixes #104

The PlaybackSpeed field must be set to 0 when paused. Otherwise Spotify
Android will correctly show the stream as paused but will still move the
playback position when redrawing the UI (and for a very short time when
resuming playback).
Copy link
Copy Markdown
Contributor Author

@aykevl aykevl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review.

Comment thread cmd/daemon/player.go
Comment thread cmd/daemon/player.go
@devgianlu devgianlu merged commit 23c4294 into devgianlu:master Oct 1, 2024
@aykevl aykevl deleted the fix-PlaybackSpeed branch October 1, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Pause" doesn't appear to send the correct paused state

2 participants