feat: improve efficiency of the decryptor#121
Merged
devgianlu merged 1 commit intodevgianlu:masterfrom Oct 12, 2024
Merged
Conversation
This was referenced Oct 7, 2024
f231486 to
7f41bd7
Compare
Contributor
Author
|
Updated:
|
The decryptor was using up a lot of time. For a ~10min song it took about twice the time that it took to run the Vorbis decoder and this time would only go up considering the exponential nature of the loop. But actually, all it did was count up a number. This can be done by a simple addition instead of a complicated loop. Hence this patch changes the loop to a simple addition.
7f41bd7 to
e7dd509
Compare
Owner
|
Love it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The decryptor was using up a lot of time. For a ~10min song it took about twice the time that it took to run the Vorbis decoder and this time would only go up considering the exponential nature of the loop.
But actually, all it did was count up a number. This can be done using a simple addition instead of a complicated loop. Hence this patch changes the loop to a simple addition.
It is 32-bits at the moment, which means it would overflow with a stream that'sUpdated to be 64 bits to make me feel better, this is extremely unlikely to ever overflow.64GB48GB big. This is entirely fixable if needed, but 48GB seems like an unlikely large stream.This replaces #120.