feat: don't seek when it's not needed#122
Merged
devgianlu merged 1 commit intodevgianlu:masterfrom Oct 12, 2024
Merged
Conversation
This seek takes around 0.5-1ms on a Raspberry Pi 3 which isn't much, but it's totally unnecessary in most cases so can be skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seek takes around 0.5-1ms (when seeking to position 0) on a Raspberry Pi 3 which isn't much, but it's totally unnecessary in most cases so can be skipped.
This is basically the same as #116 but now as a very small performance improvement.