fix: harden dealer connection lifecycle#303
Merged
devgianlu merged 1 commit intodevgianlu:masterfrom Apr 12, 2026
Merged
Conversation
Prevent panics and races during dealer close/reconnect by: - Initializing stop channels in the constructor instead of on each connect - Adding a permanent closed state that rejects Connect/writes/receivers after Close - Using non-blocking signal sends and clearing stale signals before receiving - Extracting safe read/write/close helpers that hold connMu properly - Resetting pong deadline on reconnect to avoid false timeouts
devgianlu
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional follow-ups found during implementation of #302
Prevent panics and races during dealer close/reconnect by: