Merged
Conversation
If the default config file (config.yml) doesn't exist, don't exit with an error. Instead, use a default configuration file. This removes a small point of friction when gettting started with go-librespot. On the other hand, if the config path is set explicitly using `-config_path`, do exit with an error when it cannot be found (because presumably the user made a mistake there).
This seems like a sane default, better than not setting credentials at all which results in an error.
This makes it easier to distinguish different instances of go-librespot on different devices. The error is intenionally ignored: in the unlikely case that os.Hostname() can't provide a hostname, there's no real problem and we just use the old behavior of not providing the hostname.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of failing altogether, this PR falls back to a default configuration file if
-config_pathis not set.The default configuration file would be the equivalent of: