fix: don't crash when to-be-prefetched track uri is empty#98
Closed
aykevl wants to merge 1 commit intodevgianlu:masterfrom
Closed
fix: don't crash when to-be-prefetched track uri is empty#98aykevl wants to merge 1 commit intodevgianlu:masterfrom
aykevl wants to merge 1 commit intodevgianlu:masterfrom
Conversation
I'm not sure how to trigger this exactly. It happens when playing albums, and maybe has something to do with the web player and/or switching between players. But it does happen sometimes and just crashing isn't great.
devgianlu
requested changes
Sep 21, 2024
| if next.Uri != "" { | ||
| nextId = librespot.SpotifyIdFromUri(next.Uri) | ||
| } else { | ||
| nextId = librespot.SpotifyIdFromGid(librespot.SpotifyIdTypeTrack, next.Gid) |
Owner
There was a problem hiding this comment.
Are we sure SpotifyIdTypeTrack is always the correct type? Episode might end up here too. A call to InferSpotifyIdTypeFromContextUri might be needed.
Contributor
Author
There was a problem hiding this comment.
I'm not. I'll investigate this a bit more and hope to find some reliable reproducer so I can test this with some podcasts. Until then, I'm not fully convinced yet this is a correct fix.
Thanks for the pointer towards InferSpotifyIdTypeFromContextUri!
Owner
|
This looks reasonable to me. Unlucikly it is always very unpredicatable whether the uri or gid fields will be used. Feel free to refactor the code in a function if you want to. |
aykevl
added a commit
to aykevl/go-librespot
that referenced
this pull request
Oct 1, 2024
This should be implemented some day, but until it is this at least keeps the player from crashing. This is a more conservative alternative to devgianlu#98.
aykevl
added a commit
to aykevl/go-librespot
that referenced
this pull request
Oct 1, 2024
This should be implemented some day, but until it is this at least keeps the player from crashing. This is a more conservative alternative to devgianlu#98.
Contributor
Author
|
Closing for now in favor of #110. Once I figure out what's going on here, I might make a new PR that actually implements this stuff. |
devgianlu
pushed a commit
that referenced
this pull request
Oct 1, 2024
This should be implemented some day, but until it is this at least keeps the player from crashing. This is a more conservative alternative to #98.
thilojaeggi
pushed a commit
to thilojaeggi/go-librespot
that referenced
this pull request
Oct 13, 2024
This should be implemented some day, but until it is this at least keeps the player from crashing. This is a more conservative alternative to devgianlu#98.
mcMineyC
pushed a commit
to mcMineyC/go-librespot_embedded
that referenced
this pull request
Mar 27, 2026
This should be implemented some day, but until it is this at least keeps the player from crashing. This is a more conservative alternative to devgianlu#98.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure how to trigger this exactly. It happens when playing albums, and maybe has something to do with the web player and/or switching between players. But it does happen sometimes and just crashing isn't great.
I'm sure I've seen this working as intended (fetching the next track from the
Gidfield) but because it's hard to reproduce I'm not sure how to test this further. I will keep my debug code in place to see whether the new code path indeed works as expected and will report back if it does.This fixes #97