Conversation
… through Camp-A uptime spec Mirrors the upstream API change in `mono` (PR linked from same feature branch). Two coordinated edits: 1. **YAML + CLI flags**: `componentGroups[].collapsed` → `defaultOpen`, default `true`. The flag pair flips from `--collapsed` / `--no-collapsed` to `--default-open` / `--no-default-open`. The YAML schema description now explains the field as a *seed* value (renderer is free to override on active incidents) so users reach for it correctly. 2. **Snapshot/diff plumbing**: handlers.ts, zod-schemas.ts, schema.ts, spec-field-parity.test.ts, and partial-failure-convergence.test.ts all use `defaultOpen`. Convergence fakes flipped accordingly. Generated artifacts (`api-zod.generated.ts`, `api.generated.ts`, `docs/openapi/monitoring-api.json`) refreshed via `scripts/regen-from.sh`. The Camp-A uptime contract (component-centric tracking + the new `trackingSince` map on `StatusPageBatchComponentUptimeDto`) is already type-correct from the regenerated zod schemas — no hand-coded callers in this repo. Made-with: Cursor
caballeto
deleted the
feat/status-page-component-tracking-and-default-open
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors the upstream API change in
devhelmhq/mono#261(same branch name).componentGroups[].collapsed→defaultOpen(defaulttrue). The flag pair flips from--collapsed/--no-collapsedto--default-open/--no-default-open. The YAML schema description now explains the field as a seed value (renderer is free to override on active incidents).handlers.ts,zod-schemas.ts,schema.ts,spec-field-parity.test.ts, andpartial-failure-convergence.test.tsusedefaultOpenwith semantic flip in fakes.api-zod.generated.ts,api.generated.ts,docs/openapi/monitoring-api.jsonrefreshed viascripts/regen-from.sh.trackingSincemap onStatusPageBatchComponentUptimeDto) is type-correct from the regenerated zod schemas — no hand-coded callers in this repo.Test plan
npm run lintnpm run typechecknpm testmake test-surface SURFACE=cliagainst the test stackcli status-pages groups create … --no-default-openround-trips correctly viacli status-pages groups listMade with Cursor