chore(ci): fix spec-check download step (gh api has no -o flag)#13
Merged
Conversation
`gh api ... -o <file>` silently errored ("unknown shorthand flag: 'o'")
on every invocation, so every mono-dispatched spec_updated event that
reached this repo would have bailed on the download step before
regenerating types. Switched to a `> <file>` redirect.
Discovered while debugging why the forensic spec change on mono didn't
produce auto-regen PRs here.
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh api ... -o <file>has never worked —gh apihas no-oflag (it'sgh release downloadthat does). Everyspec_updatedauto-dispatch from mono would have bailed withunknown shorthand flag: 'o'before running codegen, which explains why no auto-regen PR has ever landed on this repo after a mono spec change.> <file>redirect. Verified the spec still streams as raw JSON via theAccept: application/vnd.github.raw+jsonheader that was already set.Caught while debugging why the recent forensic spec change on mono didn't produce an auto-regen PR here.
Test plan
gh api repos/devhelmhq/<this>/dispatches -f event_type=spec_updatedwith a PAT that hasworkflowscope).Made with Cursor