fix(api): regen for typed TimingPhasesDto in HTTP check details#9
Merged
Conversation
Picks up the upstream mono fix (devhelmhq/mono#271) that replaces the misleading `Map<String, Object>` `Http.timing` schema with a typed `TimingPhasesDto`. Before regen, `Http.timing` was generated as dict[str, dict[str, Any]] | None which doesn't actually match the wire payload (a flat snake_case object of nullable ints). After regen it's the typed `TimingPhasesDto` model with fields `dns_ms`, `tcp_ms`, `tls_ms`, `ttfb_ms`, `download_ms`, `total_ms` — each nullable int. Bulk of the diff in `_generated.py` is datamodel-codegen reordering classes (Http now sorts after its new TimingPhasesDto dependency). Verified: ruff + mypy strict + 707 pytest tests pass. Made-with: Cursor
3 tasks
caballeto
added a commit
to devhelmhq/mcp-server
that referenced
this pull request
Apr 23, 2026
Vendored-spec sync to pick up the upstream mono fix (devhelmhq/mono#271) that replaces the misleading `Map<String, Object>` `Http.timing` schema with a typed `TimingPhasesDto` (nullable ints for dns_ms, tcp_ms, tls_ms, ttfb_ms, download_ms, total_ms). mcp-server has no codegen of its own (all SDK types come from the sibling `devhelm` SDK; see devhelmhq/sdk-python#9), so the only artifact change here is the vendored OpenAPI snapshot used for parity tests + the spec_updated repository_dispatch workflow. Verified: ruff + mypy strict + 57 pytest tests pass. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/devhelm/_generated.pyand the vendoreddocs/openapi/monitoring-api.jsonfrom the upstream spec to pick up devhelmhq/mono#271.Map<String, Object>schema forHttp.timingwith a typedTimingPhasesDto(nullable ints:dns_ms,tcp_ms,tls_ms,ttfb_ms,download_ms,total_ms).Http.timingwas typed asdict[str, dict[str, Any]] | None— which couldn't actually decode the real wire payload (a flat snake_case map of integers).Diff scope
Pure regen via
scripts/regen-from.sh— no hand edits:docs/openapi/monitoring-api.json— spec drop-insrc/devhelm/_generated.py— newTimingPhasesDtomodel +Http.timingretyped toTimingPhasesDto | None. Most of the line count is datamodel-codegen reordering classes by dependency (Http sorts after its new dep).Test plan
make lint(ruff check + format)make typecheck(mypy strict, 23 files, no issues)make test— 707/707 pytest tests passMade with Cursor