Handle OAuth callback errors gracefully for Google and GitHub#3
Draft
Handle OAuth callback errors gracefully for Google and GitHub#3
Conversation
Co-authored-by: youssef-ahmed-cs <127596947+youssef-ahmed-cs@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Handle Google and GitHub OAuth callback errors
Handle OAuth callback errors gracefully for Google and GitHub
Mar 6, 2026
9a4ec7c to
ab7be91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unhandled
ClientExceptions in the OAuth callback methods caused 500s on common failures like Google'sinvalid_grant(expired/reused auth code). BothcallbackGoogle()andcallbackGithub()now return structured JSON error responses instead.Changes
callbackGoogle()/callbackGithub()— wrapped intry/catchforClientException(→ 400) and\Exception(→ 500); Google'sinvalid_grantgets a distinct user-facing messageparseOAuthClientException()— private helper extracted to deduplicate error parsing logic across both providers; null-safe body parsing guards against exceptions with no response bodyOriginal prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.