fix: add error handling for missing files in SplitCommand #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, SplitCommand would call file_get_contents() without checking if the file exists, resulting in cryptic PHP warnings when the source HAR file is missing. This commit adds proper error handling that: - Checks if the file exists before attempting to read it - Checks if file_get_contents() returns false (for permission issues) - Displays clear, user-friendly error messages via SymfonyStyle - Returns Command::FAILURE for error cases Also adds a comprehensive test to verify the command fails gracefully when the source file doesn't exist.
Add test coverage for the directory path validation to ensure all error handling paths are properly tested. Changes: - Add is_dir() check to catch directory paths early - Add testSplitFailsWhenPathIsDirectory() test - Improve error message clarity for directory paths This ensures 100% coverage of the new error handling code.
deviantintegral
added a commit
that referenced
this pull request
Dec 15, 2025
🤖 I have created a release *beep* *boop* --- ## [0.5.0](v0.4.0...v0.5.0) (2025-12-15) ### Features * migrate from MacFJA/PharBuilder to Box ([#125](#125)) ([b1187c2](b1187c2)) ### Bug Fixes * add directory validation in getIds() before scandir() ([22057e0](22057e0)) * add error handling for missing files in SplitCommand ([#122](#122)) ([ed3fa82](ed3fa82)) * add type hints to SplitCommand::getSplitDestination parameters ([#123](#123)) ([c62a75a](c62a75a)) * check if a HAR repository exists before loading ([93fbb57](93fbb57)) * correct inverted logic in hasBlocked() and hasDns() methods ([2285c23](2285c23)) * use strict comparison (===) instead of weak comparison (==) in Serializer.php ([453d8f3](453d8f3)) ### Miscellaneous Chores * add missing call to SessionStart ([#119](#119)) ([51b50a3](51b50a3)) * auto-install php-pear in SessionStart hook ([#116](#116)) ([48acab5](48acab5)) * **deps:** pin ggilder/codecoverage action to 47c83da ([#118](#118)) ([85aa78d](85aa78d)) * fix newlines ([f5ded8c](f5ded8c)) * install xdebug for claude sessions ([54f3138](54f3138)) * run composer install in claude ([233d999](233d999)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, SplitCommand would call file_get_contents() without checking if the file exists, resulting in cryptic PHP warnings when the source HAR file is missing.
This commit adds proper error handling that:
Also adds a comprehensive test to verify the command fails gracefully when the source file doesn't exist.