feat: add hasConnect() and hasSsl() methods to Timings#154
Merged
deviantintegral merged 1 commit intomainfrom Dec 16, 2025
Merged
feat: add hasConnect() and hasSsl() methods to Timings#154deviantintegral merged 1 commit intomainfrom
deviantintegral merged 1 commit intomainfrom
Conversation
Add missing has*() methods for connect and ssl timing fields to maintain API consistency with other optional timing fields (blocked, dns). - Add hasConnect() method to check if connect timing is present - Add hasSsl() method to check if SSL/TLS timing is present - Add comprehensive tests for both new methods - Follow existing pattern of checking for -1.0 sentinel value This resolves the API inconsistency where connect and ssl fields used the -1.0 sentinel value but lacked the corresponding has*() methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing has*() methods for connect and ssl timing fields to maintain API consistency with other optional timing fields (blocked, dns).
This resolves the API inconsistency where connect and ssl fields used the -1.0 sentinel value but lacked the corresponding has*() methods.