test: remove redundant assertions in SplitCommandTest.php #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deviantintegral
changed the title
The assertNotEquals('modified content', $newContent) assertion is
redundant because the preceding assertEquals($originalContent, $newContent)
already verifies the content. If newContent equals originalContent, it
cannot also equal 'modified content'.
…ndTest This test is redundant because its assertions are covered by other tests: - 11/11 and 100% assertions are covered by testProgressFinishShowsCompletion - Intermediate state assertions are covered more thoroughly by testProgressAdvanceIsCalledForEachEntry (which checks for >2 distinct states) - SUCCESS status and file count are covered by testSplitMultipleEntries
The assertCount(11, $files) is redundant because the subsequent assertEquals($expectedFiles, $files) already verifies both the exact file count and the specific file names.
The assertFileExists assertion is redundant because the subsequent file_get_contents call would fail anyway if the file doesn't exist, and the assertCount(1, $files) already verifies the file count.
The assertFileExists assertion is redundant because the subsequent file_get_contents call would fail anyway if the file doesn't exist.
The assertFileExists assertions inside the loop are redundant because the subsequent file_get_contents calls would fail anyway if the files don't exist.
The assertStringContainsString('100%') assertion is redundant because
the subsequent assertMatchesRegularExpression('/100%\s*\n/') already
verifies that 100% is present in the output.
…tion
The assertTrue(hasArgument('har')) and assertTrue(hasArgument('destination'))
assertions are redundant because getArgument() would throw an exception
if the argument doesn't exist, and we're already calling getArgument()
on the next lines.
…ceIsCalledForEachEntry
The assertContains('0') and assertContains('11') assertions are redundant
because the assertGreaterThan(2, count($progressStates)) already verifies
that progress is being shown. The 11/11 final state is also verified by
testProgressFinishShowsCompletion.
The loop verifying filenames match MD5 regex pattern is redundant because the subsequent assertEquals($expectedHash, $basename) already verifies that each filename equals the expected MD5 hash of the URL. Since md5() always returns a 32-character hex string, the regex check adds no value.
deviantintegral
force-pushed
the
claude/refactor-split-command-tests-MaOpI
branch
from
afc3f0f to
99c92d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.