fix: add name validation to CIRA config to prevent 500 on invalid con…#867
Merged
madhavilosetty-intel merged 1 commit intomainfrom Mar 30, 2026
Merged
fix: add name validation to CIRA config to prevent 500 on invalid con…#867madhavilosetty-intel merged 1 commit intomainfrom
madhavilosetty-intel merged 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #867 +/- ##
=======================================
Coverage 40.24% 40.25%
=======================================
Files 114 114
Lines 10868 10866 -2
=======================================
Hits 4374 4374
+ Misses 6092 6091 -1
+ Partials 402 401 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
madhavilosetty-intel
force-pushed
the
update-cira-name
branch
2 times, most recently
from
82b682b to
7f97a4e
Compare
…figName Enforce alphanumhyphenunderscore validation (^[a-zA-Z0-9_-]+$) on the in the name would pass through to downstream operations and cause a 500 Internal Server Error. With this change, invalid names are rejected at the validation layer with a proper 4xx error. Resolves device-management-toolkit/rps#2599
madhavilosetty-intel
force-pushed
the
update-cira-name
branch
from
5d93aa4 to
6b295a1
Compare
rsdmike
approved these changes
Mar 30, 2026
|
🎉 This PR is included in version 1.22.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…figName
Enforce alphanumhyphenunderscore validation (^[a-zA-Z0-9_-]+$) on the in the name would pass through to downstream operations and cause a 500 Internal Server Error. With this change, invalid names are rejected at the validation layer with a proper 4xx error.
Resolves device-management-toolkit/rps#2599