fix: prevent kb input lock in the active KVM session #2994
Merged
+265
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaoboon
force-pushed
the
issue2591/kbInputLockedInKVM
branch
2 times, most recently
from
f71b49f to
a73d15b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes keyboard input locking in active KVM sessions by implementing event interception at the document level. The solution prevents the KVM toolkit from capturing keyboard events when users are typing in input fields, textareas, or other editable elements.
Key changes:
- Implemented lifecycle hooks and keyboard event listeners to intercept events before KVM captures them
- Added logic to detect focused input elements and stop event propagation when appropriate
- Added comprehensive unit tests covering various input element types and scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/app/devices/kvm/kvm.component.ts | Added keyboard event interception logic using capture phase listeners and cleanup in lifecycle hooks |
| src/app/devices/kvm/kvm.component.spec.ts | Added comprehensive test suite verifying keyboard event handling across different input element types |
- Added keyboard event listener in ngOnInit and handle the events in handleKeyboardEventCapture method - Added a new handleKeyboardEventCapture method to stop event propagation if the KVM session is active and if an input element has focus - Added event listener cleanup in ngOnDestroy() to prevent memory leaks - Added unit tests to verify the new functionality and ensure that keyboard events are properly handled when the KVM session is active
shaoboon
force-pushed
the
issue2591/kbInputLockedInKVM
branch
from
a73d15b to
8eba757
Compare
sudhir-intc
reviewed
Nov 20, 2025
shaoboon
requested review from
graikhel-intel,
madhavilosetty-intel and
rsdmike
sudhir-intc
approved these changes
Nov 27, 2025
RosieAMT
pushed a commit
that referenced
this pull request
Nov 28, 2025
## [3.50.2](v3.50.1...v3.50.2) (2025-11-28) ### Bug Fixes * prevent kb input lock in the active KVM session ([#2994](#2994)) ([925b7b5](925b7b5))
|
🎉 This PR is included in version 3.50.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What are you changing?
Anything the reviewer should know when reviewing this PR?
This is to resolve the #2591
The issue was reproduced in the main branch with the git commit ID: 696cd47
The solution fix was built on top of the above commit.
If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )