DEV-192; https://support.dataart.com/browse/DEV-192; #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add subcriptions update on device delete action.
apanevin
suggested changes
Nov 28, 2017
|
|
||
| public class DeviceDeleteRequest extends Body { | ||
|
|
||
| private DeviceVO device; |
Contributor
There was a problem hiding this comment.
Sending whole device object is excessively
| //TODO: only migrated to genericDAO, need to migrate Device PK to DeviceId and use directly GenericDAO#remove | ||
| @Transactional | ||
| public boolean deleteDevice(@NotNull String deviceId) { | ||
| DeviceDeleteRequest deviceDeleteRequest = new DeviceDeleteRequest(findById(deviceId)); |
Contributor
There was a problem hiding this comment.
Device's existence should be checked before creating and calling request
Filter clean up on device delete fixed.
apanevin
approved these changes
Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add subcriptions update on device delete action.