Fix acceptAlertButtonSelector matching 'Don't Allow' instead of 'Allow'#24
Merged
omnarayan merged 1 commit intodevicelab-dev:mainfrom Feb 28, 2026
Conversation
The CONTAINS[c] 'Allow' predicate matched both "Allow" and "Don't Allow" buttons, causing WDA to tap "Don't Allow" and reject permissions on real iOS devices. Changed to BEGINSWITH[c] 'Allow' to only match buttons starting with "Allow", plus an exact match for "OK" on older iOS dialogs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
175f747 to
2f5d899
Compare
Contributor
|
@maggialejandro nice catch! This one's sneaky —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
acceptAlertButtonSelectorWDA setting that incorrectly matched "Don't Allow" buttons on iOS permission dialogs, causing permissions to be rejected instead of accepted on real devices.Type of Change
Changes Made
acceptAlertButtonSelectorfromCONTAINS[c] 'Allow'toBEGINSWITH[c] 'Allow' OR label ==[c] 'OK'CONTAINS 'Allow'matched both "Allow" and "Don't Allow" buttons — WDA tapped the first match in the hierarchy, which was "Don't Allow"BEGINSWITH 'Allow'correctly matches only "Allow" and "Allow While Using App"==[c] 'OK'fallback for older iOS dialogs that use "OK" instead of "Allow"Related Issues
N/A
Testing
make test)make lint)Checklist
Additional Notes
Reproduced on a real iOS device running an app that requests microphone permission. The
setPermissionsstep withmicrophone: allowconfigured WDA's auto-alert handler, but theCONTAINS[c] 'Allow'predicate in theacceptAlertButtonSelectormatched "Don't Allow" first, rejecting the permission dialog.