fix: corebluetooth fulfill characteristics futures on peripheral disconnection
#409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonlesisz
changed the title
corebluetooth fulfill characteristics futures on peripheral di…corebluetooth fulfill characteristics futures on peripheral disconnection
qwandor
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing
corebluetoothpending subscription features.Im trying to connect to a peripheral which requires number comparison pairing.
To enforce pairing process i need to call subscribe, read or write on protected characteristic, this will open native system window and display numbers to compare.
If everything goes well then i receive OK on the subscription.
However if i cancel the system number comparison or disconnect the device during that process i will get
DeviceDisconnectedevent but those pending subscription requests are never resolved.With this fix they should be fulfilled with "Device disconnected" error