Skip to content

new icon: Mattermost (original, original-wordmark)#1955

Merged
canaleal merged 3 commits intodevicons:developfrom
dariakiseleva:new-icon-mattermost
Dec 26, 2024
Merged

new icon: Mattermost (original, original-wordmark)#1955
canaleal merged 3 commits intodevicons:developfrom
dariakiseleva:new-icon-mattermost

Conversation

@dariakiseleva
Copy link
Copy Markdown
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #868

Link to prove your SVG is correct and up-to-date.

https://handbook.mattermost.com/operations/operations/company-processes/publishing/publishing-guidelines/brand-and-visual-design-guidelines

@Snailedlt
Copy link
Copy Markdown
Collaborator

Snailedlt commented Oct 29, 2023

@devicons/devicon__reviewers This icon needs to be discussed before we can merge it. Please take a look at the linked issue: #868

@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Oct 30, 2023
@lunatic-fox
Copy link
Copy Markdown
Contributor

@devicons/devicon__reviewers This icon needs to be discussed before we can merge it. Please take a look at the linked issue: #868

It seems quite more related to technology and development than Slack, so I think it's a valid icon.

@github-actions
Copy link
Copy Markdown
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@github-actions
Copy link
Copy Markdown
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Copy link
Copy Markdown
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All svgs good. No weird artifacts and they have all been optimized.

image

@canaleal canaleal merged commit 399e336 into devicons:develop Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants