Skip to content

Add Grails original svg#238

Merged
amacado merged 4 commits intodevicons:masterfrom
weh:features/add-grails
Jul 3, 2020
Merged

Add Grails original svg#238
amacado merged 4 commits intodevicons:masterfrom
weh:features/add-grails

Conversation

@weh
Copy link
Copy Markdown
Contributor

@weh weh commented Jun 30, 2020

No description provided.

@amacado amacado added the feature:icon PR when a new icon is ready to be added to the collection label Jun 30, 2020
@amacado
Copy link
Copy Markdown
Member

amacado commented Jun 30, 2020

Hi @weh and thank you for the submission. Can you take a look at our CONTRIBUTING.md regarding this requirements for a submission:

  • At least the plain or line version of the icon is required (since those are required for the icon font)
  • Modify devicon-colors.css to include the colored version of the icon

@amacado amacado mentioned this pull request Jul 1, 2020
@amacado amacado self-requested a review July 1, 2020 17:24
Copy link
Copy Markdown
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable-background is depreceated, can you remove it from the svg's?

the grails-plain version containing a the same color as the original, could you modify that to have a clean look like our other plain-icons?

In the result i'm fine with adding 'original' as an alias like you did.

Also we have some conflicts now ;-)

@weh weh requested a review from amacado July 2, 2020 08:36
@amacado amacado merged commit 169264b into devicons:master Jul 3, 2020
@tupaschoal tupaschoal mentioned this pull request Jun 30, 2021
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants