Skip to content

Add Scala icons#239

Merged
amacado merged 3 commits intodevicons:masterfrom
weh:features/add-scala
Jul 3, 2020
Merged

Add Scala icons#239
amacado merged 3 commits intodevicons:masterfrom
weh:features/add-scala

Conversation

@weh
Copy link
Copy Markdown
Contributor

@weh weh commented Jul 1, 2020

Add Scala Icons
@amacado

@amacado amacado self-requested a review July 1, 2020 17:25
@amacado amacado added the feature:icon PR when a new icon is ready to be added to the collection label Jul 1, 2020
Copy link
Copy Markdown
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the viewBox and resolve conflicts :)

Comment thread icons/scala/scala-original-wordmark.svg Outdated
Comment thread icons/scala/scala-original.svg Outdated
Comment thread icons/scala/scala-plain-wordmark.svg Outdated
Comment thread icons/scala/scala-plain.svg Outdated
Copy link
Copy Markdown
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weh thanks for fixing the viewBox, just a last merge with devicon-colors is required :)

@amacado amacado merged commit d27e2ac into devicons:master Jul 3, 2020
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants