Skip to content

Conversation

@Snailedlt
Copy link
Collaborator

I added a new "ETL" tag. ETL stands for Extract Transform Load, and is a popular acronym for the process of transferring data from several different sources into a central data warehouse

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes #929

Link to prove your SVG is correct and up-to-date.

https://azure.microsoft.com/en-us/products/data-factory/?ef_id=_k_Cj0KCQjwgIXCBhDBARIsAELC9Zh4Zzex9jlw_bwPswepH_72rR8dqlbZ9v8uWtTX3LzVT34wZkXl-0oaAiWeEALw_wcB_k_&OCID=AIDcmmf6lw2mzf_SEM__k_Cj0KCQjwgIXCBhDBARIsAELC9Zh4Zzex9jlw_bwPswepH_72rR8dqlbZ9v8uWtTX3LzVT34wZkXl-0oaAiWeEALw_wcB_k_&gad_source=1&gad_campaignid=1635074142&gbraid=0AAAAADcJh_uBnoY4kYcUhWvoeWtqh0LFz&gclid=Cj0KCQjwgIXCBhDBARIsAELC9Zh4Zzex9jlw_bwPswepH_72rR8dqlbZ9v8uWtTX3LzVT34wZkXl-0oaAiWeEALw_wcB

https://az-icons.com/icon/data-factories

How it looks in the azure portal:
image

@Snailedlt Snailedlt requested review from a team, ConX, canaleal, lunatic-fox and weh and removed request for a team June 5, 2025 12:44
@Snailedlt Snailedlt added feature:icon PR when a new icon is ready to be added to the collection bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Jun 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)
  4. A new object is added in the devicon.json file at the correct alphabetic position as seen here

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added missing newlines, the rest looks good to me

@canaleal canaleal merged commit 688e589 into devicons:develop Jul 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants