Skip to content

Fix Jenkins Plain Icon#331

Merged
Thomas-Boi merged 3 commits intodevicons:developfrom
tariq86:feature/306-jenkins
Oct 21, 2020
Merged

Fix Jenkins Plain Icon#331
Thomas-Boi merged 3 commits intodevicons:developfrom
tariq86:feature/306-jenkins

Conversation

@tariq86
Copy link
Copy Markdown
Contributor

@tariq86 tariq86 commented Oct 20, 2020

This PR contains an updated plain Jenkins icon (as requested in PR #309), which should work better for icon fonts.

The original request for Jenkins icons was #306

@amacado amacado requested a review from Thomas-Boi October 21, 2020 19:21
@amacado amacado added the feature:icon PR when a new icon is ready to be added to the collection label Oct 21, 2020
@Thomas-Boi Thomas-Boi added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Oct 21, 2020
@Thomas-Boi
Copy link
Copy Markdown
Member

Hey @tariq86 ,

Thank you for fixing the jenkins-plain icon! I have run the peek script and your icon looks like this (top left):
image

I am satisfied with it and I'll accept your merge.

Cheers :)
Thomas

Copy link
Copy Markdown
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changing the devicon.json and the .eps file!

@Thomas-Boi Thomas-Boi merged commit 34de065 into devicons:develop Oct 21, 2020
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants