Skip to content
This repository was archived by the owner on May 19, 2025. It is now read-only.

Update osTicket to 1.17, PHP to 8.1, plugin-related updates#38

Merged
adam-dej merged 8 commits intomasterfrom
1.17.0-update
Nov 30, 2022
Merged

Update osTicket to 1.17, PHP to 8.1, plugin-related updates#38
adam-dej merged 8 commits intomasterfrom
1.17.0-update

Conversation

@adam-dej
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Collaborator

@lubo lubo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be e088ff5 the first commit? Otherwise, the plugin is broken in ae62be9, right?

Comment thread Dockerfile
@adam-dej
Copy link
Copy Markdown
Member Author

Shouldn't be e088ff5 the first commit? Otherwise, the plugin is broken in ae62be9, right?

You are correct, I'll swap the order before the final history cleanup and force-push.

Copy link
Copy Markdown
Collaborator

@lubo lubo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a0fc580 should be IMO squashed into ae62be9 as well.

Comment thread README.md Outdated
@adam-dej adam-dej requested a review from lubo November 14, 2022 13:42
Comment thread Dockerfile Outdated
@adam-dej
Copy link
Copy Markdown
Member Author

a0fc580 should be IMO squashed into ae62be9 as well.

Those breaking changes that prompted that message were introduced in 37b608a. I can squash a0fc580 into that one during the final rebase.

In the current state, if someone build in image from ae62be9, that image would contain outdated plugins that may not work (I haven't tested them). I can squash both a0fc580 and 37b608a into that one to avoid it - but I wanted 37b608a to be separate as it is a logically separate change. (Also, 37b608a can't be put before ae62be9 in its current state - I would have to remove installation of 1.17-specific plugins, and I believe that would be an unnecessary complication).

@adam-dej adam-dej requested a review from lubo November 17, 2022 09:31
Comment thread Dockerfile Outdated
@lubo
Copy link
Copy Markdown
Collaborator

lubo commented Nov 18, 2022

Go for rebase.

@adam-dej adam-dej merged commit 6390434 into master Nov 30, 2022
@adam-dej adam-dej deleted the 1.17.0-update branch November 30, 2022 11:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants