fix: update whisper-rs to 0.15.1 for macOS ARM support#7
Merged
Conversation
- Update whisper-rs: 0.14.4 → 0.15.1 - Update whisper-rs-sys: 0.13.1 → 0.14.1 - Adapt to API changes: - full_n_segments() now returns i32 directly - full_get_segment_text() replaced with get_segment() - WhisperSegment implements Display for text extraction Fixes macOS ARM build failure in v0.4.0 release (i8mm CPU feature issue) Refs #3
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughUpdated whisper-rs dependency from 0.14 to 0.15 and refactored transcriber error handling to use direct segment counting and fallback-based retrieval instead of Result-based error mapping. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Problem
The v0.4.0 release build failed for macOS ARM due to a compilation error in
whisper-rs-sys v0.13.1:The GitHub Actions macOS ARM runner doesn't support the required CPU instructions when compiling whisper.cpp with the 0.14 version.
✅ Solution
Update to whisper-rs 0.15.1, which includes:
📝 Changes
Dependencies
whisper-rs: 0.14.4 → 0.15.1whisper-rs-sys: 0.13.1 → 0.14.1API Adaptations
full_n_segments()now returnsi32directly (no Result)full_get_segment_text()replaced withget_segment()Displaytrait implementation for text extraction:format!("{}", segment)🧪 Test Plan
cargo checkpasses locally📎 References
Summary by CodeRabbit
Dependencies
Bug Fixes