Fix regression with stuttery audio after suspend#64
Merged
WinterMute merged 2 commits intodevkitPro:switch-sdl-2.28from Mar 24, 2024
Merged
Fix regression with stuttery audio after suspend#64WinterMute merged 2 commits intodevkitPro:switch-sdl-2.28from
WinterMute merged 2 commits intodevkitPro:switch-sdl-2.28from
Conversation
Author
|
I tested with a few homebrew (UAE4All2, ScummVM) that this indeed fixes the broken scratchy and stuttery audio after resuming from suspend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The switch from audren back to audout caused a regression where audio is scratchy/stuttery after suspend, i.e. when the Switch is put to sleep and woken up while homebrew is playing audio.
This was a longstanding issue and one of the reasons why cpasjuste switched from audout to audren years ago.
Unless there are compelling issues to use audout instead of audren, and the scratchy audio on wake from suspend can be fixed, we should stick with audren.
Description
Reverted the commits that switched from audren back to audout.
Existing Issue(s)
None.