various edits #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaleoAnguay
added a commit
to KaleoAnguay/js-logic
that referenced
this pull request
Feb 7, 2017
p0haku
added a commit
to p0haku/js-logic
that referenced
this pull request
Mar 11, 2017
siroisalex
pushed a commit
to siroisalex/js-logic
that referenced
this pull request
Jun 10, 2017
jennlieu
pushed a commit
to jennlieu/js-logic
that referenced
this pull request
Sep 12, 2017
klthornton
pushed a commit
to klthornton/js-logic
that referenced
this pull request
Sep 14, 2017
loganwong
pushed a commit
to loganwong/js-logic
that referenced
this pull request
Jun 9, 2018
Lorelei808
added a commit
to Lorelei808/js-logic
that referenced
this pull request
Jun 10, 2018
Lorelei808
added a commit
to Lorelei808/js-logic
that referenced
this pull request
Jun 10, 2018
Kailiwai
added a commit
to Kailiwai/js-logic
that referenced
this pull request
Jun 10, 2018
kinwail
added a commit
to kinwail/js-logic
that referenced
this pull request
Jun 11, 2018
kinwail
added a commit
to kinwail/js-logic
that referenced
this pull request
Jun 12, 2018
Newbology
added a commit
to Newbology/js-logic
that referenced
this pull request
Oct 7, 2018
sluong90
pushed a commit
to sluong90/js-logic
that referenced
this pull request
Nov 11, 2018
bflores88
added a commit
to bflores88/js-logic
that referenced
this pull request
Jan 12, 2019
kevinchguo
pushed a commit
to kevinchguo/js-logic
that referenced
this pull request
Jan 12, 2019
jessmanapul
pushed a commit
to jessmanapul/js-logic
that referenced
this pull request
Feb 9, 2019
mcarmack82
added a commit
to mcarmack82/js-logic
that referenced
this pull request
Apr 9, 2019
jonharwell
pushed a commit
to jonharwell/js-logic
that referenced
this pull request
Apr 9, 2019
micaiahcape
added a commit
to micaiahcape/js-logic
that referenced
this pull request
May 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented various edits. The only other thing I would recommend is rewriting question #13. I didn't understand what was being asked. In general, it is better to use "If..., then..." statements rather than "Consequence... if...." statements. At least, that's what my lawyerly sensibilities prefer.