Make Gridlex more modular and more extensible as a dependency#71
Merged
devlint merged 5 commits intodevlint:masterfrom Nov 16, 2017
Merged
Make Gridlex more modular and more extensible as a dependency#71devlint merged 5 commits intodevlint:masterfrom
devlint merged 5 commits intodevlint:masterfrom
Conversation
…acilitate modification externally
…ort individual parts from your node_modules
`@each $mq-key, $mq-value in $gl-mq-list/*-min-max*/ {`
to `@each $mq-key, $mq-value in $gl-mq-list{`
`$gl-mq-list-min-max` is not used.
Owner
|
Hello @mynameislau, Merged, but littles changes after: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I made a few adjustments to the way gridlex imports are orchestrated.
I isolated the breakpoints variables, so it can more easily be overriden without having to copy all the code and keeping gridlex as a dependency and benefiniting from potential minor fixes (semver minor versions)
That way you can easily import individual parts of gridlex.
This enables you to :
import your own version of gridlex-breakoints
import untouched gridlex-vars
import untouched gridlex-classes
and you are done !
All with keeping gridlex as a npm dependency without copypasting
All of this is non breaking