Create a smarter OpenAI chat client that honors model ID#58
Merged
Conversation
When using `IChatClient` API, the `ChatOptions.ModelId` is ignored by the built-in OpenAI implementation obtained by invoking `OpenAIClient.GetChatClient("model").AsIChatClient`. This is because the `GetChatClient` stores the model passed in and doesn't respect the options-specified one after initial creation.
We now align our own implementation of `IChatClient` for OpenAI so it behaves like Grok's, allowing more flexible usage while following the natural expectation set by having a writable `ChatOptions.ModelId` in the first place :).
Member
Author
|
🧪 Details on Ubuntu 24.04.2 LTSfrom dotnet-retest v0.7.1 on .NET 8.0.17 with 💜 by @devlooped |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
IChatClientAPI, theChatOptions.ModelIdis ignored by the built-in OpenAI implementation obtained by invokingOpenAIClient.GetChatClient("model").AsIChatClient. This is because theGetChatClientstores the model passed in and doesn't respect the options-specified one after initial creation.We now align our own implementation of
IChatClientfor OpenAI so it behaves like Grok's, allowing more flexible usage while following the natural expectation set by having a writableChatOptions.ModelIdin the first place :).