Conversation
|
Changes Unknown when pulling 688c9ee699591942502b5c36e90905cca5a55619 on chore/test-audio-bars into ** on master**. |
* Now points to devlucky
majames
force-pushed
the
chore/test-audio-bars
branch
from
688c9ee to
03c863d
Compare
|
Changes Unknown when pulling 03c863d9aff17fb92d62cfb389283b6b8b60baf2 on chore/test-audio-bars into ** on master**. |
There was a problem hiding this comment.
Update badges to point at devlucky
There was a problem hiding this comment.
Move logic for bucketing frequency data into Analyser (other visualisations can use this)
There was a problem hiding this comment.
Not sure if this it is giving us some value or we are getting to deep here. Like from the outside, seeing 0 , 0, 400, 400 looks really weird
There was a problem hiding this comment.
Yeah. I defs think it looks a little weird... but I do like testing the logic for clearing the canvas.
How about I use explaining variables? Like:
const canvasDefaultWidth = 400;
const canvasDefaultHeight = 400;
There was a problem hiding this comment.
Same thing here as before, I do like the draws the correct number of bars to the canvas test and I think we should keep it, but I will prefer to see something like:
expect(wrapper.instance().drawSingleBar).toHaveBeenCalledTimes(expectedNumberOfDrawedBars);What do you think? I don't think doing such calculations in the testsuite is the way to go, I think we should try to abstract that more
majames
force-pushed
the
chore/test-audio-bars
branch
from
03c863d to
b49a1f9
Compare
3 participants
Test (allthethings)