Added travis and coveralls badges to README#6
Merged
Conversation
|
Changes Unknown when pulling 067314c257013d723629fe06ca0763e99752952e on chore/coverage-stats into ** on master**. |
majames
force-pushed
the
chore/coverage-stats
branch
from
067314c to
9696cf1
Compare
|
Changes Unknown when pulling 9696cf1fd839561359dcb7455a4d8bff77e8b440 on chore/coverage-stats into ** on master**. |
zzarcon
requested changes
May 24, 2017
Member
There was a problem hiding this comment.
Can we wrap this into a package script and just yarn coverage later?
Collaborator
Author
There was a problem hiding this comment.
The command will only work when run within Travis so I didn't want to add it as a script. I'll add a yarn coverage command that makes sense for devs to run locally doe.
Member
|
I think the coveralls bot is too noisy, an we avoid somehow the comments on the PRs? what do you think? |
Collaborator
Author
|
disabled 💬 🙉 ⛔️ |
majames
force-pushed
the
chore/coverage-stats
branch
from
9696cf1 to
3a407ff
Compare
zzarcon
approved these changes
May 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫