Skip to content

Align test script with CI fast-fail order#52

Merged
devlux76 merged 2 commits intomainfrom
copilot/fix-tests-align-ci
Mar 13, 2026
Merged

Align test script with CI fast-fail order#52
devlux76 merged 2 commits intomainfrom
copilot/fix-tests-align-ci

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 13, 2026

bun run test only ran vitest, so lint and type errors were invisible to local test runs while CI caught them as separate gating steps.

Change

Updated the test script to mirror the CI pipeline sequence — lint → typecheck → unit tests — so bun run test fast-fails at the same points CI does:

// before
"test": "vitest run tests/*.test.ts tests/**/*.test.ts"

// after
"test": "bun run lint && bun run build && vitest run tests/*.test.ts tests/**/*.test.ts"

test:unit is preserved as a bare vitest runner for quick iteration without the pre-checks.

Original prompt

This section details on the original issue you should resolve

<issue_title>Fix tests to align with CI</issue_title>
<issue_description>CI is catching all kinds of misc stuff and that's great. Our test suite needs to be doing that as well. Make sure it's the first thing testing tests for. Failing lint, failing typecheck etc is failing tests, so fast fail on those items. </issue_description>

Comments on the Issue (you are @copilot in this section)


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: devlux76 <86517969+devlux76@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix tests to align with CI Align test script with CI fast-fail order Mar 13, 2026
Copilot AI requested a review from devlux76 March 13, 2026 08:48
@devlux76 devlux76 marked this pull request as ready for review March 13, 2026 08:50
Copilot AI review requested due to automatic review settings March 13, 2026 08:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the local test script to match CI’s fast-fail sequence (lint → typecheck → unit tests), so running bun run test locally surfaces the same failures CI would catch before executing Vitest.

Changes:

  • Updated test to run lint and build (typecheck) before invoking Vitest.
  • Preserved test:unit as a Vitest-only runner for faster iteration.

Comment thread package.json
"typecheck": "bun run build",
"lint": "eslint .",
"test": "vitest run tests/*.test.ts tests/**/*.test.ts",
"test": "bun run lint && bun run build && vitest run tests/*.test.ts tests/**/*.test.ts",
@devlux76 devlux76 merged commit daaeeda into main Mar 13, 2026
6 checks passed
@devlux76 devlux76 deleted the copilot/fix-tests-align-ci branch March 13, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix tests to align with CI

3 participants