Prevent catastrophic when item render or click fails. #686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolube
force-pushed
the
feat/prevent-catastrophic-failure
branch
from
3470e2f to
8e85712
Compare
…s to render or click event fails
nicolube
force-pushed
the
feat/prevent-catastrophic-failure
branch
from
8e85712 to
698e60c
Compare
nicolube
changed the title
devnatan
approved these changes
Nov 4, 2024
Owner
devnatan
left a comment
devnatan
left a comment
There was a problem hiding this comment.
Thx for your contribution :))
Inventory Framework v2 had a global error handler that was not shipped to Inventory Framework v3 unfortunately. An error handler may be a good feature for the future.
I'll publish a new release with it soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
currently, if an exeption is throwen inside a onClick catastrophic occurs.
Well what does that mean?
Item can be taken out of a menu, all inventory clicks are prevented until the same View is closed properly (Reconnect does not help).
So just wrap both in a try catch to prevent that.
IF should not break with some user of it maks a mistake.
Also added a server runner and plugin for easier testing.