Skip to content

fix: add paramiko 4.0 compatibility for NoValidConnectionsError#4

Closed
markng wants to merge 1 commit intodevnullvoid:mainfrom
roaming-panda-llc:main
Closed

fix: add paramiko 4.0 compatibility for NoValidConnectionsError#4
markng wants to merge 1 commit intodevnullvoid:mainfrom
roaming-panda-llc:main

Conversation

@markng
Copy link
Copy Markdown

@markng markng commented Jan 28, 2026

In paramiko 4.0.0+, NoValidConnectionsError moved from paramiko to paramiko.ssh_exception. Use try/except import pattern to support both paramiko 3.x and 4.x versions.

In paramiko 4.0.0+, NoValidConnectionsError moved from paramiko to
paramiko.ssh_exception. Use try/except import pattern to support
both paramiko 3.x and 4.x versions.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@devnullvoid devnullvoid self-requested a review February 22, 2026 05:42
@devnullvoid
Copy link
Copy Markdown
Owner

Hi @markng,

Thank you for this contribution! This fix has already been implemented in the codebase (see lines 15-18 in session_manager.py). We used a similar try/except pattern with AttributeError to handle the NoValidConnectionsError location change between paramiko 3.x and 4.x.

Closing this PR as the functionality is already present. We appreciate you taking the time to submit this fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants