Skip to content

ci: fix integration tests — register app, reject skips (V5)#10

Merged
devonartis merged 1 commit intodevelopfrom
fix/ci-real-integration-tests
Apr 14, 2026
Merged

ci: fix integration tests — register app, reject skips (V5)#10
devonartis merged 1 commit intodevelopfrom
fix/ci-real-integration-tests

Conversation

@devonartis
Copy link
Copy Markdown
Owner

Summary

  • CI integration tests were fake green: 14 of 15 stories skipped silently because CI never provided AGENTWRIT_CLIENT_ID or AGENTWRIT_CLIENT_SECRET
  • Fix: new setup step registers a test app with the broker via admin API (/v1/admin/auth/v1/admin/apps), exports credentials to subsequent steps
  • Added skip guard: job fails if ANY tests skip — all 15 stories must run
  • Verified locally: 15/15 passed against live broker (devonartis/agentwrit:latest)

Test plan

  • Broker starts with AA_ADMIN_SECRET
  • Admin auth returns JWT
  • App registration returns client_id + client_secret
  • All 15 integration stories pass locally with real credentials (98s)
  • CI runs all 15 stories on GitHub (this PR validates it)

Refs devonartis/agentwrit#31

Generated with Claude Code

Integration tests were fake green: 14 of 15 stories skipped
because CI never provided AGENTWRIT_CLIENT_ID or CLIENT_SECRET.

Fix: CI now registers a test app with the broker via admin API
before running tests. Also fails the job if any tests skip —
all 15 stories must run, no silent skips allowed.

Refs devonartis/agentwrit#31

Generated with Claude Code
@devonartis devonartis merged commit 0588ec6 into develop Apr 14, 2026
9 checks passed
@devonartis devonartis deleted the fix/ci-real-integration-tests branch April 14, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant