Skip to content

Conversation

@devondragon
Copy link
Owner

This pull request updates Java development environment settings, bumps the project version, and improves password policy enforcement by ensuring the common password list is sorted. The most significant changes are grouped below.

Development environment updates:

  • Updated .vscode/settings.json to set the Java home directory for language support and Gradle import tasks, ensuring consistent Java version usage in VSCode.

Project versioning:

  • Bumped the project version in gradle.properties from 3.4.2-SNAPSHOT to 3.5.0-SNAPSHOT to mark the start of a new development cycle.

Password policy improvements:

  • Modified PasswordPolicyService.java to import ArraysSort and use it when creating the ArrayWordList for the common password dictionary, ensuring the word list is sorted for more efficient lookups. [1] [2]…rraysSort for Passay wordlist initialization

…rraysSort for Passay wordlist initialization
@devondragon devondragon self-assigned this Oct 26, 2025
Copilot AI review requested due to automatic review settings October 26, 2025 17:18
@devondragon devondragon added the enhancement New feature or request label Oct 26, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR advances the project to version 3.5.0-SNAPSHOT and improves the password validation system by ensuring the common password dictionary is sorted for efficient lookups. It also includes developer-specific VS Code configuration changes.

  • Version bumped from 3.4.2-SNAPSHOT to 3.5.0-SNAPSHOT
  • Password dictionary now uses ArraysSort for optimized lookups
  • VS Code workspace configured with specific Java 17 paths

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
gradle.properties Version bump to 3.5.0-SNAPSHOT for new development cycle
src/main/java/com/digitalsanctuary/spring/user/service/PasswordPolicyService.java Added ArraysSort to ensure common password list is sorted for efficient dictionary lookups
.vscode/settings.json Added Java home paths for VS Code language support and Gradle tasks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +13 to +14
"java.jdt.ls.java.home": "/Users/devon/.local/share/mise/installs/java/17.0.2",
"java.import.gradle.java.home": "/Users/devon/.local/share/mise/installs/java/17.0.2"
Copy link

Copilot AI Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These settings contain user-specific absolute paths that will not work for other developers. Consider removing this file from version control by adding it to .gitignore, or use relative paths/environment variables that work across different development environments.

Suggested change
"java.jdt.ls.java.home": "/Users/devon/.local/share/mise/installs/java/17.0.2",
"java.import.gradle.java.home": "/Users/devon/.local/share/mise/installs/java/17.0.2"
"java.jdt.ls.java.home": "/Users/devon/.local/share/mise/installs/java/17.0.2"

Copilot uses AI. Check for mistakes.
@devondragon devondragon merged commit ac378c1 into main Oct 26, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in SpringUserFramework Oct 26, 2025
@devondragon devondragon deleted the password-tweaks branch October 26, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Development

Successfully merging this pull request may close these issues.

2 participants