Skip to content

Update doc display content#300

Merged
GuentherJulian merged 8 commits intodevonfw-tutorials:mainfrom
dixyushi:update-doc-displayContent
Aug 13, 2021
Merged

Update doc display content#300
GuentherJulian merged 8 commits intodevonfw-tutorials:mainfrom
dixyushi:update-doc-displayContent

Conversation

@dixyushi
Copy link
Copy Markdown
Contributor

No description provided.

@dixyushi dixyushi marked this pull request as ready for review August 3, 2021 08:02
@GuentherJulian GuentherJulian self-requested a review August 3, 2021 08:07
Comment thread documentation/Functions.md Outdated
3. (Optional) Path to the current directory where the user is located (relative to the workspace directory). Only needed if the directory is changed within this step.
you need two parameters for this function.

Example: displayContent(1st parameter, 2nd parameter)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we need this line here. We have an example after the parameter description. I think it is not needed to have such a line in each function

Comment thread documentation/Functions.md Outdated

Note: The title should never be empty and it is of type string.

2nd parameter i.e. An array of json objects with files, content, or images to be rendered within the Katacoda step. The use for this function is to display an image and some descriptive text. No Katacoda syntax is allowed in the files or the content!
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON in capital letters

Comment thread documentation/Functions.md Outdated

#### Details
Available attributes in the json objects:
You can use 3 attributes in the json objects array in 2nd parameter:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON

Comment thread documentation/Functions.md Outdated
3. image: Path to an image to be displayed in the Katacoda step.
2nd attribute i.e. "content": Plain text to be displayed in the Katacoda step. This Text should be following the formating of asciidoc files.

3rd attribute i.e. "image": Path to an image to be displayed in the Katacoda step.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you can mention that the image should be located in a subfolder of the playbook directory

Comment thread documentation/Functions.md Outdated

Example: displayContent(1st parameter, 2nd parameter)

1st parameter i.e. The title of the step.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a list syntax or bullet points for the parameters as it was before. So it stands out better from the text

GuentherJulian
GuentherJulian previously approved these changes Aug 12, 2021
@GuentherJulian GuentherJulian merged commit 0cf117c into devonfw-tutorials:main Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants