Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
abe1811
Merge pull request #1 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner May 28, 2021
577c462
Merge pull request #3 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner May 28, 2021
2b34824
Merge pull request #4 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 2, 2021
b9387c0
Merge pull request #5 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 2, 2021
4ab522d
Merge pull request #6 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 2, 2021
2638fc7
Merge pull request #8 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 2, 2021
4f1d935
Merge pull request #9 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 2, 2021
478cfbb
Merge pull request #10 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 4, 2021
3e8daa7
Merge pull request #11 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 4, 2021
f152024
Merge pull request #12 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 4, 2021
583cc3a
Merge pull request #13 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 4, 2021
63184fb
Merge pull request #14 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 4, 2021
7f697b7
Merge pull request #15 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 4, 2021
845fc0b
Merge pull request #16 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 4, 2021
96b6c4c
Merge pull request #17 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 4, 2021
c198698
Merge pull request #18 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 4, 2021
932bc89
Merge pull request #19 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 4, 2021
42dfb85
Merge pull request #20 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 4, 2021
1f7fde8
Merge pull request #21 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 4, 2021
c641574
Merge pull request #22 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 4, 2021
5844375
Merge pull request #23 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 4, 2021
69adbd1
Merge pull request #24 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 4, 2021
8b65839
Merge pull request #25 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 4, 2021
5778a28
Merge pull request #26 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 4, 2021
61a2749
Merge pull request #27 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 4, 2021
6adee85
Merge branch 'devonfw-tutorials:main' into main
MarcelDiessner Jun 11, 2021
f655715
Merge pull request #28 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
b0bacf2
Merge pull request #30 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
f6d58a8
Merge pull request #31 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
fc25460
Merge pull request #32 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
13e416a
Merge pull request #34 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
0fc5eaa
Merge pull request #36 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
4842275
Merge pull request #37 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
2f8c11a
Merge pull request #39 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
76130fb
Merge pull request #40 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
d6cb7e0
Merge pull request #42 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
9445446
Merge pull request #43 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
8465384
Merge pull request #44 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
cf10677
Merge pull request #45 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
5ad5454
Merge pull request #46 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
3d4b94a
Merge pull request #47 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
905ce54
Merge pull request #48 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
43cdfc3
Merge pull request #49 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
31f9064
Merge pull request #50 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
85308e9
Merge pull request #51 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
9a5447b
Merge pull request #52 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
4578558
Merge pull request #53 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
b82aa73
Merge pull request #54 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
e636b4e
Update selectChangedFiles.js
MarcelDiessner Jun 11, 2021
6e2c886
reqeust branch name form github api
MarcelDiessner Jun 11, 2021
6ee6829
Merge branch 'feature/syntaxChecking' of https://github.com/MarcelDie…
MarcelDiessner Jun 11, 2021
6f7cebd
Merge pull request #56 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
40a348b
added script to get branch
MarcelDiessner Jun 11, 2021
e819cb5
Merge pull request #57 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
d2ba227
fix
MarcelDiessner Jun 11, 2021
4f7cfdd
Merge pull request #58 from MarcelDiessner/feature/syntaxChecking
MarcelDiessner Jun 11, 2021
ab673ad
Update syntaxCheckPullRequest.yml
MarcelDiessner Jun 11, 2021
01a12eb
Update syntaxCheckPullRequest.yml
MarcelDiessner Jun 11, 2021
fa7d49f
Update syntaxCheckPullRequest.yml
MarcelDiessner Jun 11, 2021
6e72980
Update syntaxCheckPullRequest.yml
MarcelDiessner Jun 11, 2021
3300991
fix
MarcelDiessner Jun 11, 2021
9a8dcc1
Merge branch 'main' into feature/syntaxChecking
MarcelDiessner Jun 11, 2021
0a1acf1
moved get branch
MarcelDiessner Jun 11, 2021
1dc3287
Feature/syntax checking (#61)
MarcelDiessner Jun 11, 2021
b21084a
test
MarcelDiessner Jun 11, 2021
a638915
Merge branch 'main' into feature/syntaxChecking
MarcelDiessner Jun 11, 2021
d94e336
removed test conditions
MarcelDiessner Jun 11, 2021
d2f40cd
Merge branch 'feature/syntaxChecking' of https://github.com/MarcelDie…
MarcelDiessner Jun 11, 2021
770c86c
removed duplicate
MarcelDiessner Jun 11, 2021
df3890b
Merge branch 'main' into feature/syntaxChecking
SchettlerKoehler Jun 15, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 11 additions & 17 deletions .github/workflows/syntaxCheckPullRequest.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
name: Check PR Katacoda Syntax

env:
PR_NUMBER: ${{github.event.number}}
on:
pull_request_target:
branches: [ main ]
jobs:
setup-matrix:
runs-on: ubuntu-latest
env:
PR_NUMBER: ${{github.event.number}}

steps:
- name: Checkout playbooks
Expand All @@ -18,8 +17,10 @@ jobs:
run: npm install
- name: Select Changed Files
id: changedfiles
run: |
node selectChangedFiles.js
run: node selectChangedFiles.js
- name: Get branch
id: get_branch
run: node getHeadRef.js
- name: Setup matrix combinations
id: setup-matrix-combinations
run: |
Expand All @@ -34,6 +35,7 @@ jobs:
echo ::set-output name=matrix-combinations::{\"include\":[$MATRIX_PARAMS_COMBINATIONS]}
outputs:
matrix-combinations: ${{ steps.setup-matrix-combinations.outputs.matrix-combinations }}
head_ref: ${{ steps.get_branch.outputs.head_ref}}

build:
runs-on: ubuntu-latest
Expand All @@ -45,31 +47,24 @@ jobs:
uses: actions/checkout@v2
with:
repository: devonfw-tutorials/tutorial-compiler

- name: Checkout playbooks
uses: actions/checkout@v2
with:
repository: devonfw-tutorials/tutorials
ref: ${{needs.setup-matrix.outputs.head_ref}}
path: playbooks

- uses: actions/setup-node@v2-beta

- name: install TS
run: npm install typescript

- name: npm install
run: npm install

- name: run buildRun.sh --user ${{ github.actor }} --branch ${{ github.event.pull_request_target.head.ref }} --checkSyntax
run: |
sh buildRun.sh --user ${{ github.actor }} --branch ${{ github.event.pull_request_target.head.ref }} --checkSyntax -p ${{ matrix.tutorial }} -e test_console

- name: run buildRun.sh --user ${{ github.actor }} --branch ${{needs.setup-matrix.outputs.head_ref}} --checkSyntax
run: sh buildRun.sh --user ${{ github.actor }} --branch ${{needs.setup-matrix.outputs.head_ref}} --checkSyntax -p ${{ matrix.tutorial }} -e test_console
- name: Check error file existence
id: check_files
uses: andstor/file-existence-action@v1
with:
files: "./build/errors/syntaxErrors.md"

- name: Get message
id: get_message
if: steps.check_files.outputs.files_exists == 'true'
Expand All @@ -80,11 +75,10 @@ jobs:
message="${message//$'\r'/'%0D'}"
echo "${message}"
echo "::set-output name=message::$message"

- name: Request changes
if: ${{ steps.get_message.outputs.message != '' }}
uses: andrewmusgrave/automatic-pull-request-review@0.0.2
with:
repo-token: '${{ secrets.GITHUB_TOKEN }}'
event: COMMENT
body: ${{ steps.get_message.outputs.message }}
body: ${{ steps.get_message.outputs.message }}
26 changes: 26 additions & 0 deletions getHeadRef.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
const core = require("@actions/core");
const { Octokit } = require("@octokit/core");
const octokit = new Octokit({ auth: process.env.GITHUB_TOKEN });

async function getHeadRef() {
let pr = process.env.PR_NUMBER;
let ref ="";
try {
let get = await octokit.request('GET /repos/{owner}/{repo}/pulls/{pull_number}', {
owner: 'devonfw-tutorials',
repo: 'tutorials',
pull_number: pr
});
ref = get.data.head.ref;
} catch(e) {
throw e;
}
core.info(`Head Ref: ${ref}`);
core.setOutput('head_ref', ref);
}

getHeadRef().catch(err => {
console.log(err);
process.exit(1);
});