Skip to content

Tutorial-devon4jmigrate#161

Merged
ssarmokadam merged 56 commits intodevonfw-tutorials:mainfrom
dixyushi:tutorial-devon4jmigrate
Jul 14, 2021
Merged

Tutorial-devon4jmigrate#161
ssarmokadam merged 56 commits intodevonfw-tutorials:mainfrom
dixyushi:tutorial-devon4jmigrate

Conversation

@dixyushi
Copy link
Copy Markdown
Contributor

@dixyushi dixyushi commented Jul 7, 2021

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 7, 2021

Thanks for submitting your work on a (new) tutorial!

Some suggestions, which might help:

  • Title: Focus on what you want to train in a few words. Don't be too generic
  • Tutorial:
    • Address the user directly.
    • Explain why the steps are necessary.
    • Explain what are the results and why are they necessary for your next step.
    • Forward the user to more elaborate documentation on the website (deep links) for further reading

Also please find further help for creating tutorials here or more help regarding the tutorial syntax here.

You can view the generated tutorials of this PR here in a few minutes. You just have to wait for the run of the deployment action to finish.

When you think you are done writing the tutorial try the tutorial on the deveplopment area and check if you explained every step in a way someone who is trying to learn what you are teaching can understand. Ideally ask someone to have a look on what you have done and have that part double checked because this is very important.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 7, 2021

Please add a description to your pull request.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function(s) not found:

  • cd

You can find all supported functions and how to use them here.

@dixyushi dixyushi marked this pull request as ready for review July 12, 2021 14:13
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function(s) not found:

  • buildRun.sh --user devonfw-sample/devon4j-app-4tutorial restoreWorkspace

You can find all supported functions and how to use them here.

Comment thread devon4j-migrate/index.asciidoc Outdated
[step]
== Execute Migrate Command
--
executeCommand("devon java migrate", "devon java migrate", {"dir" : "devonfw/workspaces/main"})
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working directory is already ../devonfw/workspaces/main. in this case you would run this in ../devonfw/workspaces/main/devonfw/workspaces/main

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about that? In katacoda you need to change the dir. Do we have an error here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Denise, If I keep only the name of project then I have to manually navigate to "devonfw/workspaces/main" from command line in katacoda environment and then execute command for directory i.e. "devon4j-app-4tutorial" which I have added. then I have to execute migrate command

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, when we start restoreWorkspace, we only clone the git repository into the workspaces folder and set the working directory to root/devonfw/workspaces/main. Since we haven't changed the folders in katacoda yet, we would still be in the root-folder when the tutorial starts. That's why we have an cd command at the beginning. While writing the tutorial on the other hand, we would have to specify the parameter relative to the workspace directory, which is already root/devonfw/workspaces/main.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can change that if it's to confusing this way. But since we usually mean by 'relative to workspace', relative to main, we kept it that way

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is actually a bug in executeCommand. It only returns the path not the relative path. I will fix it

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Denise for the fix. It is working fine now

Copy link
Copy Markdown
Collaborator

@ssarmokadam ssarmokadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and working fine

@ssarmokadam ssarmokadam merged commit 72fba6f into devonfw-tutorials:main Jul 14, 2021
@dixyushi dixyushi linked an issue Jul 19, 2021 that may be closed by this pull request
@ssarmokadam ssarmokadam mentioned this pull request Aug 9, 2021
@mustafaokyay mustafaokyay added devon4j quick start Tutorial focuses on getting things done fast with little explanation labels Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devon4j quick start Tutorial focuses on getting things done fast with little explanation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

devon4j migrate

5 participants