-
Notifications
You must be signed in to change notification settings - Fork 65
Disable uninstall for corepack and npm #1536
Copy link
Copy link
Labels
corepackenhancementNew feature or requestNew feature or requestinternalNothing to be added to CHANGELOG, only internal storyNothing to be added to CHANGELOG, only internal storynpmnode package managernode package manageryarnpackage manager alternative to npmpackage manager alternative to npm
Milestone
Metadata
Metadata
Assignees
Labels
corepackenhancementNew feature or requestNew feature or requestinternalNothing to be added to CHANGELOG, only internal storyNothing to be added to CHANGELOG, only internal storynpmnode package managernode package manageryarnpackage manager alternative to npmpackage manager alternative to npm
Type
Projects
Status
✅ Done
Task summary
As a corepack, yarn and npm user I don't want to uninstall corepack since this will break my installation.
I also don't want to uninstall npm with is my default package manager and break my node installation.
So we need to disable the uninstall command for corepack and npm.
Additional context
This issue is related to #907 and PR #1467
When the user does
ide uninstall corepackoride uninstall npmand the according tool is found to be installed, he should get the following message:I would recommend to implement this as a feature already in
NodeBasedCommandletso we can centralise the log message and logic and inCorepackandNpmwe just enable this "feature" e.g. by overriding a new methodisDisableUninstall().