java.lang.NullPointerException when trying to auto-complete after ide repository

[WorkingAmeise]

Expected behavior

As a IDEasy User, I want autocompletion in the repository commandlet so that i can see valid options to input

Actual behavior

ide repository An unexpected error occurred!
We are sorry for the inconvenience.
Please check the error below, resolve it and try again.
If the error is not on your end (network connectivity, lack of permissions, etc.) please file a bug:
https://github.com/devonfw/IDEasy/issues/new?assignees=&labels=bug&projects=&template=bug.md&title=java.lang.NullPointerException
java.lang.NullPointerException
        at java.base@21.0.2/java.nio.file.Files.provider(Files.java:104)
        at java.base@21.0.2/java.nio.file.Files.isDirectory(Files.java:2318)
        at com.devonfw.tools.ide.property.PathProperty.completeValue(PathProperty.java:113)
        at com.devonfw.tools.ide.property.Property.complete(Property.java:412)
        at com.devonfw.tools.ide.property.Property.apply(Property.java:337)
        at com.devonfw.tools.ide.context.AbstractIdeContext.completeCommandlet(AbstractIdeContext.java:968)
        at com.devonfw.tools.ide.context.AbstractIdeContext.complete(AbstractIdeContext.java:919)
        at com.devonfw.tools.ide.commandlet.CompleteCommandlet.run(CompleteCommandlet.java:53)
        at com.devonfw.tools.ide.context.AbstractIdeContext.applyAndRun(AbstractIdeContext.java:867)
        at com.devonfw.tools.ide.context.AbstractIdeContext.run(AbstractIdeContext.java:798)
        at com.devonfw.tools.ide.cli.Ideasy.runOrThrow(Ideasy.java:89)
        at com.devonfw.tools.ide.cli.Ideasy.run(Ideasy.java:52)
        at com.devonfw.tools.ide.cli.Ideasy.main(Ideasy.java:29)
        at java.base@21.0.2/java.lang.invoke.LambdaForm$DMH/sa346b79c.invokeStaticInit(LambdaForm$DMH)


Error in property setup:
Value is required and cannot be empty.
Invalid arguments: "repository"

Steps to reproduce (bug) / Use Case of feature request (enhancement)

1. type ide repository and a space

2. press tab

3. type ide repository set

4. press tab

Related/Dependent Issues

Comments/Hints:

Affected version:

• OS: Windows
• Browser: /

[hohwille]

Bug is here:

IDEasy/cli/src/main/java/com/devonfw/tools/ide/property/PathProperty.java

Lines 111 to 113 in 45a25d5

	Path parent = path.getParent();
	String filename = path.getFileName().toString();
	if (Files.isDirectory(parent)) {

We need to add

if (parent == null) {
  parent = Path.of(".");
}

Java APIs are easily leading to errors and are not designed robust unfortunately.

[hohwille]

what is to be expected, when the user type "ide repository" and press tab? according to my understanding, this command is used to "clone, build or import" pre-configured repositories. So I guess the candidates should be one of these three words?
is that right?

First of all we have to distinguish what should happen for completion of PathProperty in general (FileProperty and PathProperty):
This should behave like in regular bash completion for commands like cd or rm where I can provide a file or folder as argument.
The problem of this issue is that this was implemented wrong causing NPEs and that should be fixed with this issue.

To go further, I enforced via review that we introduced a RepositoryProperty that also extends PathProperty to allow customized auto-completion for RepositoryCommandlet. So if you are asking what should really happen when the user pressed tab key after ide repository then the user should get a completion of the configured repositories. That is the *.properties from $IDE_HOME/settings/repositories will be completed. For our default configuration from here this would be just IDEasy. In other projects we sometimes have 10 or more repositories configured.
Also consider that in devonfw-ide the repositories folder was named projects and we have to fallback to that if the repositories folder does not exist. For devonfw-ide we have 3 repos configured - see here.

First we should fix the generic path completion for files and folders in one PR.
The completion for RepositoryProperty should later be done in a separate PR.

[hohwille]

Fixed with PR #956