Skip to content

#797 added macOS arm64 download url for vscode#1837

Open
shodiBoy1 wants to merge 3 commits intodevonfw:mainfrom
shodiBoy1:feature/797-vscode-arm64-mac
Open

#797 added macOS arm64 download url for vscode#1837
shodiBoy1 wants to merge 3 commits intodevonfw:mainfrom
shodiBoy1:feature/797-vscode-arm64-mac

Conversation

@shodiBoy1
Copy link
Copy Markdown
Contributor

This PR fixes #797

Implemented changes:

  • Added macOS ARM64 (darwin-arm64/stable) download URL for VSCode in VsCodeUrlUpdater
  • Previously, ARM64 Macs fell back to the x64 download via Rosetta emulation, which caused slice is not valid mach-o file errors because the x64 Electron binary is not Rosetta-compatible
  • After this fix and ide-urls regeneration, ARM64 Macs will download the native darwin-arm64 build

Checklist for this PR

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 20, 2026

Coverage Report for CI Build 24693055016

Coverage increased (+0.01%) to 70.563%

Details

  • Coverage increased (+0.01%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 3 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

3 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/url/tool/vscode/VsCodeUrlUpdater.java 3 70.59%

Coverage Stats

Coverage Status
Relevant Lines: 15140
Covered Lines: 11136
Line Coverage: 73.55%
Relevant Branches: 6734
Covered Branches: 4299
Branch Coverage: 63.84%
Branches in Coverage %: Yes
Coverage Strength: 3.1 hits per line

💛 - Coveralls

@shodiBoy1
Copy link
Copy Markdown
Contributor Author

the gatekeeper-related problems from this issue are fixed in PR #1794:

  • the "Operation not permitted" error when copying .ide.software.version into the .app bundle is gone we just don't copy it into the bundle anymore, so the codesign seal stays intact.
  • the "Electron cannot be opened" Gatekeeper popup is fixed by clearing quarantine attributes (xattr -cr) and ad-hoc codesigning unsigned .app bundles after extraction.
  • the missing executable permission on the Electron binary should also be fixed since codesign --force --deep restores permissions during signing.

whats still open:

the VsCodeUrlUpdater was missing the darwin-arm64/stable URL, so on arm64 Macs it falls back to the x64 download (Rosetta fallback). That x64 Electron binary doesn't work and crashes with "slice is not valid mach-o file".

@shodiBoy1 shodiBoy1 requested a review from hohwille April 20, 2026 22:11
@shodiBoy1 shodiBoy1 moved this from 🆕 New to Team Review in IDEasy board Apr 20, 2026
@shodiBoy1 shodiBoy1 added vscode Microsoft visual studio code macOS specific for Apple MacOS labels Apr 20, 2026
@shodiBoy1 shodiBoy1 marked this pull request as ready for review April 20, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macOS specific for Apple MacOS vscode Microsoft visual studio code

Projects

Status: Team Review

Development

Successfully merging this pull request may close these issues.

vscode not working on mac

2 participants