Skip to content

#1850: Added Test-jar configuration to ide-cli#1851

Merged
hohwille merged 1 commit intodevonfw:mainfrom
laim2003:#1850-cli-test-jar-configuration
Apr 24, 2026
Merged

#1850: Added Test-jar configuration to ide-cli#1851
hohwille merged 1 commit intodevonfw:mainfrom
laim2003:#1850-cli-test-jar-configuration

Conversation

@laim2003
Copy link
Copy Markdown
Contributor

This PR fixes #1850

Implemented changes:

  • Added test jar configuration to ide-cli, allowing other modules to potentially depend on and access helper classes etc. from the CLI module (e.g. IdeTestContext)

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Apr 24, 2026
@laim2003 laim2003 moved this from 🆕 New to 🏗 In progress in IDEasy board Apr 24, 2026
@laim2003 laim2003 self-assigned this Apr 24, 2026
@laim2003 laim2003 added the test related to testing and QA label Apr 24, 2026
@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 24888794883

Coverage decreased (-0.03%) to 70.66%

Details

  • Coverage decreased (-0.03%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 4 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

4 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/git/repository/RepositoryCommandlet.java 3 70.98%
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java 1 78.33%

Coverage Stats

Coverage Status
Relevant Lines: 15271
Covered Lines: 11251
Line Coverage: 73.68%
Relevant Branches: 6798
Covered Branches: 4343
Branch Coverage: 63.89%
Branches in Coverage %: Yes
Coverage Strength: 3.11 hits per line

💛 - Coveralls

@laim2003
Copy link
Copy Markdown
Contributor Author

@laim2003 laim2003 marked this pull request as ready for review April 24, 2026 12:23
@laim2003 laim2003 moved this from 🏗 In progress to Team Review in IDEasy board Apr 24, 2026
Copy link
Copy Markdown
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laim2003 thanks for your PR. Exactly the correct pattern to get access to our cli test code in the tests of gui. 👍

@github-project-automation github-project-automation Bot moved this from Team Review to 👀 In review in IDEasy board Apr 24, 2026
@hohwille hohwille merged commit ac5fa7e into devonfw:main Apr 24, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in IDEasy board Apr 24, 2026
@hohwille hohwille added this to the release:2026.05.001 milestone Apr 24, 2026
@hohwille hohwille added internal Nothing to be added to CHANGELOG, only internal story SCM software-configuration-management (github actions, internal processes, git or github utilization) labels Apr 24, 2026
@laim2003 laim2003 deleted the #1850-cli-test-jar-configuration branch April 24, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Nothing to be added to CHANGELOG, only internal story SCM software-configuration-management (github actions, internal processes, git or github utilization) test related to testing and QA

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Add test-jar configuration in ide-cli

3 participants