Skip to content

#1866 implement claude url updater#1871

Open
AdemZarrouki wants to merge 10 commits intodevonfw:mainfrom
AdemZarrouki:feature/1866-claude-url-updater
Open

#1866 implement claude url updater#1871
AdemZarrouki wants to merge 10 commits intodevonfw:mainfrom
AdemZarrouki:feature/1866-claude-url-updater

Conversation

@AdemZarrouki
Copy link
Copy Markdown
Contributor

@AdemZarrouki AdemZarrouki commented Apr 28, 2026

This PR fixes #1866

Implemented changes:

  • Added ClaudeUrlUpdater using GithubUrlReleaseUpdater

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 28, 2026

Coverage Report for CI Build 25378667720

Coverage increased (+0.03%) to 70.759%

Details

  • Coverage increased (+0.03%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 14 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

14 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/url/updater/UpdateManager.java 13 0.0%
com/devonfw/tools/ide/version/VersionSegment.java 1 90.03%

Coverage Stats

Coverage Status
Relevant Lines: 15422
Covered Lines: 11373
Line Coverage: 73.75%
Relevant Branches: 6882
Covered Branches: 4409
Branch Coverage: 64.07%
Branches in Coverage %: Yes
Coverage Strength: 3.12 hits per line

💛 - Coveralls

@AdemZarrouki AdemZarrouki marked this pull request as ready for review April 28, 2026 13:19
@AdemZarrouki AdemZarrouki moved this from 🆕 New to Team Review in IDEasy board Apr 28, 2026
@AdemZarrouki AdemZarrouki assigned MarvMa and unassigned MarvMa Apr 28, 2026
@AdemZarrouki AdemZarrouki requested a review from MarvMa April 28, 2026 13:23
Copy link
Copy Markdown
Contributor

@MarvMa MarvMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work. Looks really good to me and i like that you used the new method for the github release url creation. 🥳

@AdemZarrouki AdemZarrouki moved this from Team Review to 👀 In review in IDEasy board Apr 29, 2026
@AdemZarrouki
Copy link
Copy Markdown
Contributor Author

I excluded the MUSL builds because they are consistently mismatching when i tested the changes in UpdateInitiator. Also the version 2.1.120 doesn't exist as release in the release page of claude-code so i introduced EXCLUDED_VERSION so that we dont't download the version.

@AdemZarrouki AdemZarrouki force-pushed the feature/1866-claude-url-updater branch from ad30cb2 to d2d9bc2 Compare May 5, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

Create ClaudeUrlUpdater

3 participants