Skip to content

#1102: Signing IDEasy MSI Installer#1877

Merged
hohwille merged 3 commits intodevonfw:mainfrom
ducminh02:1102-sign-msi-installer-workflow
May 5, 2026
Merged

#1102: Signing IDEasy MSI Installer#1877
hohwille merged 3 commits intodevonfw:mainfrom
ducminh02:1102-sign-msi-installer-workflow

Conversation

@ducminh02
Copy link
Copy Markdown
Contributor

@ducminh02 ducminh02 commented Apr 29, 2026

This PR fixes #1102

Implemented changes:

  • Integrated SignPath MSI Signing: Added automated code signing for Windows MSI installers using the SignPath GitHub Action.

  • Dual-Workflow Support: Enabled signing for both SNAPSHOT releases in nightly-build.yml and official releases in release.yml.

  • OIDC Authentication: Added id-token: write permissions to allow secure, secret-less authentication between GitHub Actions and SignPath.

  • Artifact Pipeline Update: Refactored the build process to upload unsigned binaries as temporary artifacts, sign them via SignPath, and distribute only the signed versions.

  • Git Configuration: Updated .gitignore to ensure .github workflow changes are correctly tracked and not blocked by global dotfile rules.


Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 29, 2026

Coverage Report for CI Build 25373879645

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+0.005%) to 70.733%

Details

  • Coverage increased (+0.005%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 2 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

2 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java 1 78.33%
com/devonfw/tools/ide/version/VersionSegment.java 1 90.55%

Coverage Stats

Coverage Status
Relevant Lines: 15396
Covered Lines: 11348
Line Coverage: 73.71%
Relevant Branches: 6878
Covered Branches: 4407
Branch Coverage: 64.07%
Branches in Coverage %: Yes
Coverage Strength: 3.12 hits per line

💛 - Coveralls

@ducminh02 ducminh02 self-assigned this May 4, 2026
@ducminh02 ducminh02 moved this from 🆕 New to 👀 In review in IDEasy board May 4, 2026
@ducminh02 ducminh02 requested a review from hohwille May 4, 2026 12:48
@hohwille hohwille added this to the release:2026.05.001 milestone May 5, 2026
Copy link
Copy Markdown
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ducminh02 thanks for recreating the change as a new PR.
As I wrote in the issue ticket I fixed the configuration on signpath and will now retry it.

@hohwille hohwille self-assigned this May 5, 2026
@hohwille hohwille added workflow GitHub actions (CI,CD,update urls/CVEs) release related to release commandlet and releases of IDEasy windows specific for Microsoft Windows OS labels May 5, 2026
@hohwille hohwille merged commit 0a9d804 into devonfw:main May 5, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in IDEasy board May 5, 2026
@hohwille hohwille changed the title Signing IDEasy MSI Installer #1102: Signing IDEasy MSI Installer May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release related to release commandlet and releases of IDEasy windows specific for Microsoft Windows OS workflow GitHub actions (CI,CD,update urls/CVEs)

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

IDEasy MSI installer not working (unsigned)

3 participants