#1695: Clone settings to temporary directory, analyse, and then move#1878
Open
areinicke wants to merge 18 commits intodevonfw:mainfrom
Open
#1695: Clone settings to temporary directory, analyse, and then move#1878areinicke wants to merge 18 commits intodevonfw:mainfrom
areinicke wants to merge 18 commits intodevonfw:mainfrom
Conversation
Collaborator
Coverage Report for CI Build 25167683820Coverage decreased (-0.2%) to 70.487%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions51 previously-covered lines in 5 files lost coverage.
Coverage Stats💛 - Coveralls |
…n' of https://github.com/areinicke/IDEasy into feature/1695-clone-settings-to-temp-dir-for-verification
satorus
reviewed
Apr 30, 2026
Co-authored-by: Robin Wenzel <robin@die-wenzels.de>
Contributor
Author
|
Thanks for the review. I have integrated the changes. |
satorus
reviewed
Apr 30, 2026
satorus
approved these changes
Apr 30, 2026
laim2003
suggested changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1695
Implemented changes:
$IDE_ROOT/_ide/tmp/projects/<project name>) where it is analyzed for validity. We check whether an ide.properties file exist either at the top level or within a settings folder at the top level. Only if this passes, do we create a new project at$IDE_ROOT/<project name>and move the files from the temporary location to the final location. The temporary folder is fully deleted after this process.Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal#Note: In some places, I used
getFileAccess()to copy and subsequently delete files. I am aware that there is a move function. However, this was always failing for some reason