Skip to content

#1844: Fix VSCode plugin installation progress freezing#1879

Open
laert-ll wants to merge 4 commits intodevonfw:mainfrom
laert-ll:bug/1844-vscode-freezes-at-installing-plugins-step-on-linux
Open

#1844: Fix VSCode plugin installation progress freezing#1879
laert-ll wants to merge 4 commits intodevonfw:mainfrom
laert-ll:bug/1844-vscode-freezes-at-installing-plugins-step-on-linux

Conversation

@laert-ll
Copy link
Copy Markdown
Contributor

@laert-ll laert-ll commented Apr 30, 2026

This PR fixes #1844

Implemented changes:

  • The outputListener was called twice per output message: once after stdout finished, once after stderr, iterating the full queue both times. This caused the VSCode plugin progress bar to increment twice per plugin, hitting 100% halfway through making it look frozen. Fix: wait for both streams to finish, then invoke the listener once.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 30, 2026

Coverage Report for CI Build 25334060192

Coverage increased (+0.01%) to 70.657%

Details

  • Coverage increased (+0.01%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 14 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

14 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/process/ProcessContextImpl.java 14 81.21%

Coverage Stats

Coverage Status
Relevant Lines: 15357
Covered Lines: 11309
Line Coverage: 73.64%
Relevant Branches: 6856
Covered Branches: 4386
Branch Coverage: 63.97%
Branches in Coverage %: Yes
Coverage Strength: 3.11 hits per line

💛 - Coveralls

@laert-ll laert-ll self-assigned this Apr 30, 2026
@laert-ll laert-ll moved this from 🆕 New to 🏗 In progress in IDEasy board Apr 30, 2026
@laert-ll laert-ll marked this pull request as ready for review April 30, 2026 08:10
@laert-ll laert-ll moved this from 🏗 In progress to Team Review in IDEasy board Apr 30, 2026
@areinicke areinicke self-requested a review April 30, 2026 08:43
@areinicke areinicke self-assigned this Apr 30, 2026
Copy link
Copy Markdown
Contributor

@areinicke areinicke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work and I don't see any issue with the changes made. Nice job!

@areinicke areinicke added vscode Microsoft visual studio code linux specific for linux OS (debian, ubunutu, suse, etc.) plugins related to plugins (for Eclipse, Intellij, VSCode, etc.) CLI IDEasy command-line-interface (parsing args, etc.) labels May 4, 2026
@areinicke areinicke moved this from Team Review to 👀 In review in IDEasy board May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLI IDEasy command-line-interface (parsing args, etc.) linux specific for linux OS (debian, ubunutu, suse, etc.) plugins related to plugins (for Eclipse, Intellij, VSCode, etc.) vscode Microsoft visual studio code

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

ide install vscode or ide vscode freezes at "installing plugins" step on Linux

3 participants