using system tar on macOS to extract .pkg payloads#1889
Open
shodiBoy1 wants to merge 2 commits intodevonfw:mainfrom
Open
using system tar on macOS to extract .pkg payloads#1889shodiBoy1 wants to merge 2 commits intodevonfw:mainfrom
shodiBoy1 wants to merge 2 commits intodevonfw:mainfrom
Conversation
Collaborator
Coverage Report for CI Build 25333993806Coverage decreased (-0.002%) to 70.643%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions91 previously-covered lines in 1 file lost coverage.
Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #796
Implemented changes:
.pkgfiles contain aPayloadthats a gzipped cpio archive, but the old code tried to read it as gzipped tarevery
.pkginstall crashed (e.g. AWS CLI on Mac)./usr/bin/tar(bsdtar), which handles gzip + cpio automatically.Checklist for this PR
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal